annotate_models icon indicating copy to clipboard operation
annotate_models copied to clipboard

problem annotation exclude controllers

Open igortice opened this issue 5 years ago • 2 comments

when I run the command, regardless of whether I configure and have the controller ignored, the command keeps generating annotations for the controllers

Commands

Captura de tela de 2019-07-15 09-21-18 Captura de tela de 2019-07-15 09-21-32

$ annotate --exclude controllers

Version

  • annotate version 2.7.5
  • rails version Rails 6.0.0.rc1
  • ruby version 2.6.3

igortice avatar Jul 15 '19 12:07 igortice

Same problem here,

  • 'exclude_controllers' => 'true' is not being respeted at auto_annotate_models.rake

  • There is no annotate --exclude controllers option parameter.

  • 'exclude_helpers' => 'true' and * 'exclude_factories' => 'true' are also being ignored!

Running v2.7.5.

vizcay avatar Aug 19 '19 19:08 vizcay

Still happening with v3.0.3 and Rails v6.0.0:

  1. Created new Rails project with postgres.
  2. Generated a simple model with rails g model.
  3. Executed rails g annotate:install and edited auto_annotate_models.rake.
  4. Changed exclude_controllers to true.
  5. Executed bundle exec rake annotate_models.
  6. The gem still annotated controllers.

@ctran are you willing to review a PR for this bugfix?

vizcay avatar Nov 29 '19 13:11 vizcay