librosa.feature.melspectrogram function type error

[basisvectors]

very small typo

https://github.com/ctralie/GraphDitty/blob/master/SongStructure.py#L168

    S = librosa.feature.melspectrogram(y, sr=sr, n_mels=128, hop_length=hop_length)

throws TypeError: melspectrogram() takes 0 positional arguments but 1 positional argument (and 2 keyword-only arguments) were given fix:

    S = librosa.feature.melspectrogram(y=y, sr=sr, n_mels=128, hop_length=hop_length)

thank you for making this code available, your papers were very insightful.

[bmcfee]

This isn't a typo, it's just that graphditty was written (long) before librosa 0.10.0 made positional arguments a requirement. But yes, graphditty could/should be updated to support 0.10.0+

[ctralie]

Yes, thanks all! Perhaps I should work on a pull request for similarity network fusion into librosa?

On Wed, Mar 29, 2023 at 9:21 AM Brian McFee @.***> wrote:

This isn't a typo, it's just that graphditty was written (long) before librosa 0.10.0 made positional arguments a requirement. But yes, graphditty could/should be updated to support 0.10.0+

— Reply to this email directly, view it on GitHub https://github.com/ctralie/GraphDitty/issues/11#issuecomment-1488603275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWDZR3VIICA4YJIYANU73W6QZORANCNFSM6AAAAAAWL2ORAE . You are receiving this because you are subscribed to this thread.Message ID: @.***>