chef-redis icon indicating copy to clipboard operation
chef-redis copied to clipboard

PID file is not customisable

Open tigris opened this issue 12 years ago • 2 comments

I notice in the default redis.conf file it tries to set /var/run/redis/redis_$PORT.pid as the pid file. However, this is never where the PID file ends up. I am using the standard "package" recipe and I'm on ubuntu, so I assume this is just stock standard for the /etc/init.d script that the OS package management puts in place, since it uses start-stop-daemon, it needs to know the location of the pid file.

In any case, I just found it quite confusing that the PID file is customisable in redis, but then never even used.

tigris avatar Nov 15 '12 07:11 tigris

I've just created a pull request from my fork that has changed the config file to match that of the full redis 2.4.* example. All options are customisable (Except those that are depreciated).

Check it out here until @ctrabold accepts my PR (#13) - https://github.com/tarnfeld/chef-redis

tarnfeld avatar Nov 17 '12 10:11 tarnfeld

A side note, I successfully upgraded the 0.0.5 version of this cookbook to 0.0.6 in production with little or no downtime (only during the redis restart), it should be a seamless switch.

tarnfeld avatar Nov 17 '12 10:11 tarnfeld