Kosuke Chris Tseng Yoshioka
Kosuke Chris Tseng Yoshioka
Oh man your commits are not verified -- https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#begin-coding-your-solution-in-a-pull-request
Looks good! Thank you for fixing your commits!
@Santhosh-Sellavel can do you can review and test?
Looks related to https://github.com/Expensify/App/issues/12000
> Got it, so does it need to be internal as per this comment? https://github.com/Expensify/App/issues/12000#issuecomment-1296576574 I think i'm wrong about that. They seem like separate issues.
Seems like https://stackoverflow.com/questions/31515999/how-to-remove-all-html-tags-from-a-string has a better regex option. Strangely we don't do this anywhere else either. I think we should also validate the end result on the PHP side, and...
@s77rt thanks for your proposal. Let me try doing a PHP side error handler first and see how that goes
Sorry @trjExpensify going to go back on what I said, and bring this back internal. My reasoning is as a rule of thumb, we always should have error catches as...
The error will look a little different because its an error being returned form the php side. Following how the code in the Form works at the moment.
Yeah, I'm trying to see if I can make that happen. Currently I only know how to do that as a pending error, meaning the user would have to click...