Craig Tiller

No it doesn't.

I think it might make sense to move this one into include/grpcpp/channel_interface.h, and not in the impl directory, since it's exposed in the top level interface and pretty necessary for...

It would probably be good to do this as something that doesn't require a socket mutator: that interface isn't actually public nor supported - and we'll probably eagerly break it...

Without a reproduction this is very hard to pin down... any chance of re-running with ASAN (since I suspect a use-after-free or similar *somewhere*)

Is there a callstack for the crash? This fix is almost certainly the wrong thing to do.

@ralphchung didn't we delete that variable recently?

Looks like this is still needing some call sites updated?

We've considered this in the past in some other contexts and arrived at a similar conclusion: it would be better to fail the rpc rather than crash (and I think...

This change will be deeply impactful to performance. We'll need to find a different way.