magento2-configurator icon indicating copy to clipboard operation
magento2-configurator copied to clipboard

Two suggestions

Open SilvanLaroo opened this issue 7 years ago • 0 comments

Hi,

Thank you for this great module. I have two suggestions:

  • Can you make your private functions protected? This way I can override them from my own extension
  • In the Config file (CtiDigital\Configurator\Model\Component\Config) in the setConfig functions you skip existing values. But I want to set a config to NULL, now the check things that the value is already the same but it's not in the core_config_table yet. You should check if the value is available, like this: if ($value == $existingValue && $this->scopeConfig->isSetFlag($path, $scope)) {.

SilvanLaroo avatar Apr 21 '17 06:04 SilvanLaroo