Charles Tapley Hoyt

Results 421 comments of Charles Tapley Hoyt

@mberr already did some legwork for this in #602

If AstraZeneca wants to pay for some consulting work done for this, I think the best strategy would be to divest from `torchdrug` completely. The package looked enticing initially but...

the pipeline has become a proper frankenstein monster at this point

Couldn't this also be related to the rank-based evaluator having a random component to it? Alternatively, I wonder if there's a reason why using a bigger dataset causes this issue

When you reload the triples, did you maintain the same entity to id and relation to id mappings? You should check that they're the same

can you check? dump the entity_ids and relation_ids dict the first time you load it with: ```python tf = TriplesFactory.from_path(TRIPLE) with open('entities.json', 'w') as file: json.dump(tf.entity_ids, file, indent=2) with open('relations.json',...

@ralphabb would you be interested in giving this PR a review?

> > @ralphabb would you be interested in giving this PR a review? > > Sorry, I can't :(. I have a backlog to clear and some deadlines coming up....

despite the promise of more complex tensor support in the last few versions of PyTorch, there are still many features missing that make it not yet possible. Let's relegate that...