extractAllToAsync error

[lucy1564351]

Never execute “callback()”

[100tomer]

+1

[100tomer]

For me it worked just switching those lines.. but I don't want to fork this great npm package. Do you know maybe when this changed happened? because I did work for me like a month ago

[troylu8]

Here is a simple self contained example, using [email protected]

When overwrite is true, the callback is never called. It worked for me with overwrite off

const Zip = require('adm-zip');

const zip = new Zip("./myzip.zip");

zip.extractAllToAsync("./dest", 
    true, // when overwrite is true, callback is never called. 
    false, 
    (err) => console.log("callback called")
);

[Linya-IronMan]

+1

[Jellfedora]

+1

[Jellfedora]

Here is a simple self contained example, using [email protected]

When overwrite is true, the callback is never called. It worked for me with overwrite off

const Zip = require('adm-zip');

const zip = new Zip("./myzip.zip");

zip.extractAllToAsync("./dest", 
    true, // when overwrite is true, callback is never called. 
    false, 
    (err) => console.log("callback called")
);

True or false dont work for me after upgrade 0.5.10 to 0.5.12

[ZoltanT-RD]

+1

[ahaubenstock]

+1

[5saviahv]

fixed in repo

[Arkellys]

Fix released on v0.5.13