adm-zip icon indicating copy to clipboard operation
adm-zip copied to clipboard

Published 20 hours ago • verified publisher icon cthackers

Fix parameter initialization bug of extractAllToAsync

Open robincodex opened this issue 3 years ago • 4 comments

issue cthackers#389 Due to the wrong initialization order, an error will be caused when three parameters are given and the last parameter is a callback function.

robincodex avatar Nov 29 '21 11:11 robincodex

Note: this also closes #407 and closes #388

JustusFluegel avatar Dec 11 '21 21:12 JustusFluegel

Thanks for picking this up!

leinelissen avatar Dec 13 '21 10:12 leinelissen

@iacobnasca @5saviahv Could you maybe take a look at releasing this :)? I broke functioning code unwittingly by upgrading beyond v0.5.7. As the upgrade is a patch version, I wouldn't expect the API to change per semver.

Thanks for all the hard work!

leinelissen avatar Jan 07 '22 13:01 leinelissen

@iacobnasca @5saviahv I have the same issue here! Can you take a look?

rodsguilherme avatar Jan 20 '22 15:01 rodsguilherme