videojs-hotkeys icon indicating copy to clipboard operation
videojs-hotkeys copied to clipboard

Published 20 hours ago • verified publisher icon ctd1500

feat: add `enableSeekPause` option

Open EastSun5566 opened this issue 1 year ago • 3 comments

Hi @ctd1500 ,

Thanks for the great plugin!

After I press the right/left arrow keys to seek video will cause a pause when it is playing. I think just using the currentTime method to seek will keep playing state. No need to keep track current playing state.

Please let me know what you think. Thank you!

EastSun5566 avatar Nov 30 '22 17:11 EastSun5566

The pause/play is there for consistency with how the seekbar works when using the mouse: #41.

You could add a new option like enableSeekPause, default to true for compatibility.

ctd1500 avatar Dec 01 '22 06:12 ctd1500

Thank you for explaining that!

enableSeekPause sounds like a good option. I will turn this PR into a draft and then implement it.

EastSun5566 avatar Dec 01 '22 15:12 EastSun5566

Hi @ctd1500 ,

Sorry for being a little bit late.

I added the enableSeekPause option for the previous discussion & also update README.md. Please take a look & let me know what you think!

EastSun5566 avatar Dec 24 '22 14:12 EastSun5566