Chris de Almeida

Results 161 comments of Chris de Almeida

oh... I didn't realize there would be so many missing semicolons. to unblock this, what we would ask is to change the configured rules such that the minimal amount of...

- This was a deliberate change. ([see issue](https://github.com/expressjs/body-parser/issues/288)) - Unfortunately, it was not highlighted very well in the [release info](https://github.com/expressjs/body-parser/releases/tag/v2.0.0-beta.1) and [history.md](https://github.com/expressjs/body-parser/blob/master/HISTORY.md#200-beta1--2021-12-17) -- [we will address that](https://github.com/expressjs/body-parser/issues/626). - To continue...

cc @sdellysse @jonchurch @wesleytodd @inigomarquinez

> @ctcpip do you consider this the "successor PR" to #282 ? If so, I'll close mine with a comment pointing people here @sdellysse yes

> Is there any easier smaller chunks we could piece out and land to make this refactor easier to follow? @wesleytodd I suggest: - use the split diff view rather...

this PR is meant to land in body-parser v2 and is thus targeting the `2.x` branch. [the PR for `2.x` to merge to `master`](https://github.com/expressjs/body-parser/pull/66) lists dropping support for node below...

deleting the 2.x branch had the effect of closing this PR. #544 was opened to replace it

I mentioned this in the meeting yesterday, but I did take a stab at running it and tests in the browser, and ran into a couple walls. The status quo...

and now this needs a rebase again! 😄

this needs to be multer v3, as v2 needs to go out with the v1 api due to a security issue that requires a breaking change