Cesar Talledo
Cesar Talledo
Thanks @thaJeztah and @vvoland for the latest round of reviews, I've updated the code following your suggestions. PTAL when you have a chance.
> Overall LGTM, but left one nit. Also, please squash the commits ❤️ Question @vvoland : is the squashing necessary? The commits are pretty clean and squashing them would actually...
> Yes we do squash commits that are not separate changes on their own, or they don't make the changes clearer. > > For example, I don't think [befb128](https://github.com/moby/moby/commit/befb128ad40ad02a1c452e45b9c0e9787d2a1378) is...
Hi @thaJeztah, @vvoland, I think this PR is ready for merging now (and FYI, all failures in CI are unrelated). What's the process to do so?
Thanks @thaJeztah for the latest round of feedback, I've incorporated all of it. PTAL when you have a chance so we can merge this PR.
> LGTM > > (nit: last commit could be squashed though 😅) Thanks! (yes I've squashed it now).
Hi @zhongcloudtian, so that we can help you, please provide as much info as possible on your setup and if possible a minimal example that we can use to reproduce...
Hi @vvoland, @thaJeztah, I can't reproduce this with Docker 28.0.1, either with the containerd image store or with the docker image store. ``` $ docker system df TYPE TOTAL ACTIVE...
Hi @Teachh, thanks for giving Sysbox a try. If I understand correctly, you are trying to install Sysbox on a K8s cluster with nodes using Ubuntu 23.04 (rather than Ubuntu...
Hi @Teachh, Thanks for the info, that clarifies the problem, and it's not related to the version of Ubuntu. Rather, sysbox-deploy-k8s only works on K8s cluster, not on k3s clusters...