libzippp icon indicating copy to clipboard operation
libzippp copied to clipboard

Updated the first example

Open gizmocuz opened this issue 1 year ago • 2 comments

gizmocuz avatar Jul 29 '22 11:07 gizmocuz

Hi @gizmocuz, thanks for the PR. Can you please explain what's wrong with the current example ? Also, can you remove the std:: namepsace ? Thanks !

ctabin avatar Aug 01 '22 15:08 ctabin

Nothing is really wrong it just is more c++ and now also displays that the points should be deleted

I was always learned to always declare the namespace instead of using the ‘use namespace ….’ Specially if you might include third party libraries. This way it is clear it’s from std. The example also does not need the ‘use namespace std;’ this way and it are only a few variables

gizmocuz avatar Aug 02 '22 11:08 gizmocuz

@gizmocuz I agree with you that one should avoid using namespace ... to avoid conflicts. However, the goal is to show some simple example without the extra-burden of handling namespaces, which is libzippp unrelated.

So, I really appreciate your input, but I'm a little bit reluctant to merge this PR because I don't see any real documentation improvement...

ctabin avatar Aug 17 '22 21:08 ctabin