werft icon indicating copy to clipboard operation
werft copied to clipboard

PROPOSAL: [github] Keep pulling annotations from non-main commits

Open corneliusludmann opened this issue 3 years ago • 1 comments

In https://github.com/csweichel/werft/commit/d5e1218fcdecca5c6a09fcb6b00b81f34b5adc03 you removed the support of annotations in commits. To address my concern I raised in https://github.com/gitpod-io/ops/issues/965#issuecomment-1027781646, I would propose a solution like the following that ignores commit annotations for the main branch only.

corneliusludmann avatar Mar 02 '22 18:03 corneliusludmann

Unfortunately just ignoring those annotations on the main branch would still break other branches. One of the cases we need to solve is that a branch is taken from main where the last commit has an annotation.

We could consider trying to diff the branch to main (the default branch) and only look at the differing commits. WDYT?

csweichel avatar Mar 07 '22 19:03 csweichel