Cody (Xuecheng) Zhang
Cody (Xuecheng) Zhang
@hoyhbx this is something like a _force_ upgrade, right? I think adding a new field may be better and wouldn't break the existing behavior. And may need to address which...
> Maybe the operator should reject the request to enable binlog if the pump does not exist. This may be done with webhook.
TiDB-Operator didn't have a well-implemented webhook now. So using CEL may be a good solution.
`discovery` is mainly used for bootstrapping the TidbCluster, so some fields are not well-supported yet. What scenarios do you need to update them?
I got it. Could you help to add labels and annotations update for the discovery service?
@adamf-db how about adding version stings as #5213
> Support customizing the upgrade sequence for different versions of a component. Any suggestion about how to customize the order from the users' side?
> > > Support customizing the upgrade sequence for different versions of a component. > > > > > > Any suggestion about how to customize the order from the...
@grovecai PTAL
@hi-rustin the components update order is defined in https://github.com/pingcap/tidb-operator/blob/ae97a5724bc4e70c04d1cbf3f9b749c279035639/pkg/controller/tidbcluster/tidb_cluster_control.go#L147 and for the new version, it can be extracted with https://github.com/pingcap/tidb-operator/blob/ae97a5724bc4e70c04d1cbf3f9b749c279035639/pkg/apis/pingcap/v1alpha1/tidbcluster.go#L126 but for the old version, a similar approach can be...