rake-nltk icon indicating copy to clipboard operation
rake-nltk copied to clipboard

Published 20 hours ago • verified publisher icon csurfer

Don't fail if nltk downloads don't work

Open ysgit opened this issue 6 years ago • 5 comments
trafficstars

hi @csurfer, thanks for your work here!

I found I had to make this change in order to be able to be able to install the package as part of a serverless app to deploy on AWS lambda. In that context it doesn't really make sense to force download the NLTK data as part of the install of your package. In fact, the install failed because it didn't have access to nlltk at build time.

ysgit avatar Jan 08 '19 19:01 ysgit

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b55f14da7aff45553b6b648a94e899a916a on ysgit:setup-without-nltk into e36116d6074c5ddfbc69bce4440f0342355ceb2e on csurfer:master.

coveralls avatar Jan 08 '19 19:01 coveralls

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b55f14da7aff45553b6b648a94e899a916a on ysgit:setup-without-nltk into e36116d6074c5ddfbc69bce4440f0342355ceb2e on csurfer:master.

coveralls avatar Jan 08 '19 19:01 coveralls

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b55f14da7aff45553b6b648a94e899a916a on ysgit:setup-without-nltk into e36116d6074c5ddfbc69bce4440f0342355ceb2e on csurfer:master.

coveralls avatar Jan 08 '19 19:01 coveralls

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b55f14da7aff45553b6b648a94e899a916a on ysgit:setup-without-nltk into e36116d6074c5ddfbc69bce4440f0342355ceb2e on csurfer:master.

coveralls avatar Jan 08 '19 19:01 coveralls

hey @csurfer did you get the chance to take a look at this?

ysgit avatar Feb 12 '19 17:02 ysgit