pyquora icon indicating copy to clipboard operation
pyquora copied to clipboard

Published 20 hours ago • verified publisher icon csu

Make Python 3 compatible

Open csu opened this issue 10 years ago • 9 comments

Aiming for Python 2.6+ and Python 3.3+ compatibility.

csu avatar Dec 22 '14 20:12 csu

I started a Python 3 branch that I will begin work in. Feel free to fork and request into it.

csu avatar Dec 22 '14 20:12 csu

How about leaving python 2 behind and making python 3 branch as the master branch?

rohithpr avatar Dec 24 '14 15:12 rohithpr

We should be able to write code that is both Python 2 and Python 3 compatible. That work is happening in the python3 branch right now, and when it's working, we'll merge it into master.

On Wed, Dec 24, 2014 at 4:36 PM, Rohith PR [email protected] wrote:

How about leaving python 2 behind and making python 3 branch as the master branch?

Reply to this email directly or view it on GitHub: https://github.com/csu/pyquora/issues/24#issuecomment-68059046

csu avatar Dec 24 '14 15:12 csu

Oh, okay.

rohithpr avatar Dec 24 '14 15:12 rohithpr

Have you considered keeping one branch and incrementally working towards 2.x and 3.x support? This seems an easier approach than branching-off to support Python 3 and then merging it back in. With adequate testing (such as by using tox) every commit should preserve functionality in the same codebase and work towards a 2.x/3.x-compatible codebase.

svisser avatar Jan 01 '15 21:01 svisser

The python3 branch is intended to be both Pyrhon 2 and 3 compatible.

On Thu, Jan 1, 2015 at 11:01 PM, Simeon Visser [email protected] wrote:

Have you considered keeping one branch and incrementally working towards 2.x and 3.x support? This seems an easier approach than branching-off to support Python 3 and then merging it back in. With adequate testing (such as by using tox) every commit should preserve functionality in the same codebase and work towards a 2.x/3.x-compatible codebase.

Reply to this email directly or view it on GitHub: https://github.com/csu/pyquora/issues/24#issuecomment-68498130

csu avatar Jan 01 '15 21:01 csu

How is the Python 3 branch coming along?

edwinksl avatar Jan 23 '16 04:01 edwinksl

Don't think it got very far. You can pick it up, if you want to.

On Jan 22, 2016, 8:54 PM, at 8:54 PM, Edwin Khoo [email protected] wrote:

How is the Python 3 branch coming along?

Reply to this email directly or view it on GitHub: https://github.com/csu/pyquora/issues/24#issuecomment-174141519

csu avatar Jan 23 '16 04:01 csu

Cool, let me take a look. I am curious if this library violates Quora's TOS since it is basically scraping its web pages.

edwinksl avatar Jan 23 '16 05:01 edwinksl