ronn icon indicating copy to clipboard operation
ronn copied to clipboard

Windows build failing to correctly import the DLLs

Open y-71 opened this issue 2 years ago • 3 comments

I found this repo yesterday, I loved the work and wanted to port it for windows.

I made this change to the CMakeLists.txt file:

if (MSVC)
file(GLOB TORCH_DLLS "${TORCH_INSTALL_PREFIX}/lib/*.dll")
add_custom_command(TARGET ronn
                   POST_BUILD
                   COMMAND ${CMAKE_COMMAND} -E copy_if_different
                   ${TORCH_DLLS}
                   $<TARGET_FILE_DIR:ronn>)
endif (MSVC)

which generated the build files for MSVC.

I then wanted to test the standalone version but got these errors:

image image

When checking the artefacts folder I found that these two DLLs were actually copied correctly: image

y-71 avatar Aug 29 '21 18:08 y-71

Fix: I fixed it by copying the DLLs to the Standalone folder itself.

The Standalone app doesn't want to open nonetheless.

y-71 avatar Aug 29 '21 19:08 y-71

Hi @tawfik741. What kind of error do get your when trying to open the compiled standalone app?

csteinmetz1 avatar Aug 29 '21 19:08 csteinmetz1

Hi @csteinmetz1 . The problem is that I don't get any error.

I tried to run it from powershell to follow execution logs but nothing happens. No errors, nothing.

y-71 avatar Aug 30 '21 00:08 y-71