postcss-plugins icon indicating copy to clipboard operation
postcss-plugins copied to clipboard

Color Helpers

Open Antonio-Laguna opened this issue 2 years ago • 4 comments

Extracting and abstracting color functions to its own package that gets distributed across different plugins instead of being copied over

Antonio-Laguna avatar May 01 '22 15:05 Antonio-Laguna

This should have all of the functions we've been using.

I think the summary is:

  • Create folders and files as needed
  • Add documentation that was lost given most of it needs JSDoc for licensing
  • Ensuring names are consistent

From this, I feel like the next step would be to create vanity files that export all the things and that get bundled and then start to cleaning up and make sure checks aren't blowing but I can be obviously wrong.

Antonio-Laguna avatar May 03 '22 18:05 Antonio-Laguna

I like all of this!

I would not have thought of giving each it's own file but I prefer this over the big fat files we had before.

This was very daunting in the github UI, but became much more clear once I pulled it locally were I could easily browse the package as a whole :)

romainmenke avatar May 14 '22 09:05 romainmenke

@romainmenke as we discussed, I've added a little script that hashes the files we want to track on external sources, you can verify it works by just changing the order in the array

Antonio-Laguna avatar May 21 '22 09:05 Antonio-Laguna

@romainmenke I've finished what we discussed, I'm not sure about the import and tree-shakeability especially there. I remember that during our internal discussions you did some testing for this, can you check how we're faring now? I think we're sacrificing a bit of DX here but I'm OK as long as we're not creating a massive bundle.

Antonio-Laguna avatar Jun 11 '22 11:06 Antonio-Laguna

@romainmenke I've done a final review here and I think this is good to go too :)

Antonio-Laguna avatar Jan 31 '23 11:01 Antonio-Laguna

Nice! you do the honors :)

romainmenke avatar Jan 31 '23 11:01 romainmenke