postcss-plugins
postcss-plugins copied to clipboard
Color Helpers
Extracting and abstracting color functions to its own package that gets distributed across different plugins instead of being copied over
This should have all of the functions we've been using.
I think the summary is:
- Create folders and files as needed
- Add documentation that was lost given most of it needs JSDoc for licensing
- Ensuring names are consistent
From this, I feel like the next step would be to create vanity files that export all the things and that get bundled and then start to cleaning up and make sure checks aren't blowing but I can be obviously wrong.
I like all of this!
I would not have thought of giving each it's own file but I prefer this over the big fat files we had before.
This was very daunting in the github UI, but became much more clear once I pulled it locally were I could easily browse the package as a whole :)
@romainmenke as we discussed, I've added a little script that hashes the files we want to track on external sources, you can verify it works by just changing the order in the array
@romainmenke I've finished what we discussed, I'm not sure about the import and tree-shakeability especially there. I remember that during our internal discussions you did some testing for this, can you check how we're faring now? I think we're sacrificing a bit of DX here but I'm OK as long as we're not creating a massive bundle.
@romainmenke I've done a final review here and I think this is good to go too :)
Nice! you do the honors :)