Cedric Staub

Results 119 comments of Cedric Staub

Sorry for being a bit absent, was on vacation for a while -- going to take a look at this soon.

@dray92 I don't think this can be merged as-is, but feel free to pick up this branch and work on it if you want to get this change merged. Probably...

FYI, I'm trying to get this into v3, and x5u/x5t support at least for JWK (though not for JWS) was merged into master in #242.

I'm not planning on working on this at the moment, but pull requests are welcome!

Have to concur with @mbyczkowski here, that's a lot to ~implement~ import as a dependency. Any chance this can be split out into its own package?

Also, to clarify, by "split out into its own package" I mean have the secp256k1 implementation in a package outside of btcd that can be imported without pulling in the...

I believe this is actually correct, the ES512 scheme (which is perhaps named confusingly) uses P-521 keys and hashes the data with SHA-512. In this case the expected bit size...

The `ed25519.PublicKey` and `ed25519.PrivateKey` types are both aliases for `[]byte`, making them effectively already pointers. So it'd be an additional layer of indirection if they were to be handled as...

@samu-gataca It's explained in my previous comment. What else do you need to know? I do have a refactor open for a v3 with an abstracted interface for keys to...

From the standard, about x5c ordering: > The certificate containing the public key corresponding to the key used to digitally sign the JWS MUST be the first certificate. This MAY...