jss icon indicating copy to clipboard operation
jss copied to clipboard

Published 20 hours ago • verified publisher icon cssinjs

Styles created multiple times when using function values

Open sergnek opened this issue 4 years ago • 8 comments

Expected behavior: Duplicate styles shouldn't be created.

Describe the bug: On every component render, in which useStyles prop changes, new duplicate styles are created. I've managed to reproduce the bug in Codesandbox. To see it:

  1. Open codesandbox link from below
  2. Inspect red text element and see styles applied
  3. Click on button few times to cause component re-render
  4. Inspect some another element on the page and the red text again.
  5. Notice duplicate styles The styles are duplicated only for elements styled with css selector. If you check styles on the element with container class, you'll see there is no duplication there.

Codesandbox link: https://codesandbox.io/s/react-jss-playground-7ftrs?file=/index.js

Versions (please complete the following information):

  • jss: 10.1.1
  • Browser [e.g. chrome, safari]: any
  • OS [e.g. Windows, macOS]: any 79044719-7820f180-7c0f-11ea-9134-42442b8c84af

sergnek avatar Jul 03 '20 11:07 sergnek

same issue: https://github.com/cssinjs/jss/issues/1360

qhxin avatar Jul 06 '20 07:07 qhxin

same for "^10.3.0". #1360 is more about Firefox, this one actually represents that issue related to all browsers/OS. Also material-ui not involved

LAKnoKAL avatar Jul 21 '20 09:07 LAKnoKAL

I have a change i've been with messing with that should address this, and make createUseStyles / useStyle work in concurrent mode, If you want to try it.

half-halt avatar Aug 01 '20 03:08 half-halt

I have run the same issue. It seems like the problem with Function rules (jss-plugin-rule-value-function) and any nested rules (jss-plugin-nested)

vlazh avatar Aug 13 '20 17:08 vlazh

Same problem here. Any solution yet?

tokiroto avatar Oct 12 '20 05:10 tokiroto

Been experiencing the same issue, dropping a +1 on this.
Been noticing performance impact from this.

just-Bri avatar Oct 21 '20 22:10 just-Bri

This is a major concern on my application. I see the issue is resolved on #1360, but not merged because of a CI config problem. D= If someone can address the merge issue, I'll be forever in debt.

naripok avatar Oct 31 '20 11:10 naripok

This is a major concern on my application. I see the issue is resolved on #1360, but not merged because of a CI config problem. D= If someone can address the merge issue, I'll be forever in debt.

It looks like they just need to update the test snapshots to reflect the new code

just-Bri avatar Oct 31 '20 11:10 just-Bri