csscomb.js icon indicating copy to clipboard operation
csscomb.js copied to clipboard

Preserve CRLF line endings

Open jdalton opened this issue 6 years ago • 3 comments

This PR preserves CRLF line endings and addresses #367, #498, #572, #578, #592, #593.

Update:

Still needs tests.

Update:

I'm manually testing on Windows and finding some issues with this PR. I'll update as I resolve them 👷

Update:

I'll add logic to detect existing line endings used to avoid using os.EOL in certain situations.

jdalton avatar Apr 21 '19 03:04 jdalton

@jdalton, is this PR still WIP?

tonyganch avatar May 19 '19 13:05 tonyganch

@tonyganch

, is this PR still WIP

Yes! I still need add detection of newline use based on the nearest other newline instead of using ‘os.EOL’.

Update:

I'm getting closer. I've added a nearestNewline() helper and got it working. I needed to feed the plugins the text, so once I clean things up and push we can bikeshed all that.

jdalton avatar May 19 '19 13:05 jdalton

Please tell me what's wrong with this edit?

StadnikovP avatar Jan 27 '21 08:01 StadnikovP