Andrew Bradley

The "multiple data points per scrape" behavior seems wrong to me. It appears to make `period` pointless, and also causes data loss for `sum` metrics. Quoting the screenshots above, emphasis...

> I don't think it simply takes the last data point.... with sum, i think it sums all the datapoints. I wish you were correct, but I'm worried because the...

Another concerning tidbit from the code: There is code to aggregate datapoints for `GetMetricStatistic` calls, but the `GetMetricData` codepaths *do not do that!* `GetMetricStatistic` codepath: https://github.com/nerdswords/yet-another-cloudwatch-exporter/blob/f5ddcf4323dc97034491114d4074ae672cfc411f/pkg/promutil/migrate.go#L155-L186 `GetMetricData` codepath, single datapoint,...

Makes sense. The goal is not speed, but to give a meaningful exit code based on **syntactic** errors, not **semantic** errors. Incremental builds are able to skip the emit step...

> Not sure it's possible to access the #194 commits from the forked repo, will just copying and leaving a comment with the issue id near the fix be OK?...

I created PR #5 for this.

I noticed that the johanblumenberg README has a list of features it adds which are not in the upstream library: https://github.com/johanblumenberg/ts-mockito#johanblumenbergts-mockito Maybe we can try to port all of those...

I sent a support ticket to npm support requesting a transfer of the @typestrong scope. If we want, and if they approve the transfer, we can publish ts-mockito under the...

I like moving to TypeStrong. Github will let me transfer this repository to TypeStrong today. Is there more to discuss, or are we ready to do that right now?

Transfer complete. You should still have full access. If the permissions got dropped for some reason, let me know and I'll be sure to fix it.