GoogleTestAdapter icon indicating copy to clipboard operation
GoogleTestAdapter copied to clipboard

Push Microsoft/TestAdapterForGoogleTest changes upstream.

Open spebl opened this issue 6 years ago • 3 comments
trafficstars

I've been working on merging/molding our changes to work within the existing framework provided by main GoogleTestAdapter repository. I've had to make a few changes on how the project template and localization are included since we have been relying on our build system to do some work for us on that end, but I believe these changes this should now work more generally. Sorry for the large PR but there is quite the cumulation of changes that have built up, along with a ton of resource files being added. I've attempted to merge as best as I could in my development fork, but will fix any outstanding conflicts that may arise from the PR.

Please let me know of any issues or changes that need to be made here to keep it in line with the current repo, or if there are specific changes that look good and others that we should discard.

spebl avatar May 08 '19 21:05 spebl

Wow - I will have a look, but it will take me probably in the order of a couple of weeks, since I'm busy with other stuff right now, I fear...

csoltenborn avatar May 10 '19 06:05 csoltenborn

Of course! No rush on this at all, I expect it to take a while to go through. In the meantime, I'll make sure the AppVeyor build is passing with the changes.

spebl avatar May 10 '19 18:05 spebl

Codecov Report

Merging #288 into master will decrease coverage by 1.27%. The diff coverage is 72.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   71.47%   70.19%   -1.28%     
==========================================
  Files         110      117       +7     
  Lines        4147     4345     +198     
  Branches      640      670      +30     
==========================================
+ Hits         2964     3050      +86     
- Misses        969     1066      +97     
- Partials      214      229      +15
Flag Coverage Δ
#Integration 54.68% <67.23%> (-0.47%) :arrow_down:
#Unit 57.42% <53.61%> (-0.7%) :arrow_down:
Impacted Files Coverage Δ
...estAdapter/TestAdapter/DataConversionExtensions.cs 81.25% <ø> (ø) :arrow_up:
...VsPackage.Shared/GoogleTestExtensionOptionsPage.cs 0% <ø> (ø) :arrow_up:
...Shared/OptionsPages/GoogleTestOptionsDialogPage.cs 0% <ø> (ø) :arrow_up:
...r/ProcessExecution/MessageBasedDebuggerAttacher.cs 84.61% <ø> (ø) :arrow_up:
...tAdapter/Settings/TestPropertySettingsContainer.cs 0% <ø> (ø)
...apter/TestAdapter/Settings/TestPropertySettings.cs 0% <ø> (ø)
GoogleTestAdapter/Core/GoogleTestConstants.cs 82.35% <ø> (ø) :arrow_up:
...red/OptionsPages/TestExecutionOptionsDialogPage.cs 0% <ø> (ø) :arrow_up:
...ared/OptionsPages/LocalizedDescriptionAttribute.cs 0% <ø> (ø)
...stAdapter/Settings/TestPropertySettingsProvider.cs 0% <ø> (ø)
... and 59 more

codecov[bot] avatar May 16 '19 21:05 codecov[bot]