Chico Sokol

Results 41 comments of Chico Sokol

Sorry, I wasn't clear enough. To generate the war you should execute the script: $ scripts/mvn-package.sh If you generate the build directly with maven (mvn package) it will modify js/css...

I you can leave it open. It makes sense to find a solution integrated with maven. ## Chico Sokol On Wed, Sep 24, 2014 at 10:39 AM, monitorjbl [email protected] wrote:...

I prefer to find a way to customize mvn package and remove the shell script. It's more natural since our project is based on maven. ## Chico Sokol On Wed,...

My idea is to run grunt during the package phase, and grunt should be configured to touch the files in the target/mamute-version/ directory only (this was how it was done...

Hi Milad, sorry for the delay. I think this could be a problem with the encoding of the properties file. If I am not mistaken, Java properties file are encoded...

Hi @MatejBalantic! Are you planning to address the comments made by @leocwolter? This PR is pretty useful, would be great if you could fix this small issues to ship that...

@khajavi thanks for the contribution! I suppose you've tested this modifications in your machine, but is hard to accept such a complex PR without unit tests. I've just finished reviewing...

Hi, I think that the parameters that caused the test do fail should be inside of the error message, so the it would be easy to find the cause of...

You're right, @marcphilipp. But notice that is still hard to read it, and if the test had failed for some other reason than an assertion in the parameter value, it...

If I have something like this: ``` java @DataPoints public static double[] datapoints = { 2.0, 4.0 }; @Theory public void myTheory(double d) throws Exception { double pow = BogousMath.pow(d,...