Longze Chen

Reviewing this now but meanwhile please remove this merge commit https://github.com/CenterForOpenScience/waterbutler/pull/334/commits/be645cc8f9279350aa864bddbb49d6d278f9880b and use rebase, thanks. @birdbrained

Thanks for reporting the issue @smathot and 👍 for the details. You are right about the cause of the failure. 1. We disabled the response type `token` to force the...

After further look, I discovered the reason that we disabled the `token` as response type is because it is the legacy implicit flow. This is no longer recommended and is...

> So basically this means you have switched to the PKCE grant flow? Not yet, this is the second / future part of our OAuth server upgrade which is supported...

Apology for losing track of this! Have you been able to fix issue with the Authorization code flow? I found a [better page](https://auth0.com/docs/authorization/flows) that explains the differences between the three...

@TomBaxter Let's sit down and do an in-person review for this.

Update: secondary PR https://github.com/TomBaxter/waterbutler/pull/1 pending.

Update: a second secondary PR https://github.com/TomBaxter/waterbutler/pull/2 pending.

@icereval thanks. Just fyi that this PR contains code from https://github.com/CenterForOpenScience/waterbutler/pull/283 which adds Cloudfiles as a provider. You might want to take a look at that one as well.

Update: given that your changes are only style fixes (including fixing issues introduced by yourself), I cherry-picked and rebased the full PR into 2 commits, one from Addison and one...