ECPy icon indicating copy to clipboard operation
ECPy copied to clipboard

Published 20 hours ago • verified publisher icon cslashm

Typing support

Open ledhed2222 opened this issue 4 years ago • 4 comments

Hi there - I'm working with a team that's using ECPy as a dependency. We'd like to add types to ECPy. Is it possible to add types given the versions you support?

ledhed2222 avatar Feb 12 '21 07:02 ledhed2222

Yes you can make any PR and I ll' review it and merge it if appropriate. You can also PM me if you want to discuss, but it's better to have tech discussion here. Can you give more detail about what you want/need to add

cslashm avatar Feb 12 '21 08:02 cslashm

happy to make the PR - but need some info:

  1. what versions of python are you committed to supporting? looks like 2.7 and 3.x. Can you confirm? Is it really necessary to keep 2.7 compatibility?
  2. looks like there is no concept of developer dependencies using poetry for example. to do this, we'd want to have type checking be verified automatically somehow. one option is using pre-commit with mypy. this would allow us to avoid the use of CI

ledhed2222 avatar Mar 12 '21 02:03 ledhed2222

bump :)

ledhed2222 avatar Apr 03 '21 02:04 ledhed2222

  1. You can remove 2.7 compat
  2. Hmm...I'm not familiar with those techno, but they seem interesting, Let's go for using that

cslashm avatar Apr 06 '21 12:04 cslashm