Csaba Kiraly

Results 57 comments of Csaba Kiraly

I think replacement is not handled correctly if both txs were waiting in the reorder queue. I have to revisit that, and maybe we should add a test on it...

@rjl493456442 , I've committed this fix for now, but there are other options. Curious which one you would prefer: - I think the check above is expensive as `GetCanonicalTransaction` pulls...

- implemented `HasCanonicalTransaction` - seperated `hasTx` (in pool), from `chainTx` - added and simplified test code @fjl , this is now ready for review

To extend on what @arnetheduck was saying, if we assume a system with uniform nodes, uniform latencies between nodes, and unsaturated bandwidth (i.e. we reason in time steps), we can...

> @cskiraly thanks for the insightful input. A couple of clarifications: > > ### Approach 1 > How do you define "happy path"? And what would be reasons for "diffusion...

You can have a dedicated folder for each run. I'm for example using it with this parameter: `--results-root results/$(date -Iseconds)` , but of course you can use any other pattern,...

Thanks for signalling these, but we don't accept typo-only PRs. We prefer fixing typo and grammar as we update the content as part of the technical discussion.