Csiki

Results 10 issues of Csiki

First, thank you for your library, I am using it for more than a year (since v2.5) and it's perfect! When I refreshed my new devices, I noticed that for...

If the client has a banned coin then it does not finish the coin connection confirmation. It won't participate in the next phase, but checks the coins whether they are...

size/M

The client should be able to create the block filters on its own if requested by the user. ### Description Currently the client gets the filters from the backend, this...

Should be harmless

size/L

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/nullable-warnings?f1url=%3FappId%3Droslyn%26k%3Dk(CS8600) Converting null literal or possible null value to non-nullable type. We can safely change the return value to string since the only caller just uses IsNullOrEmpty, don't differentiate between...

size/XS

Simplified expressions/conditions

size/S

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1865-ca1867 Came up in https://github.com/zkSNACKs/WalletWasabi/pull/12986

size/S

Upgrading ThirdPartyFeeProvider to support list of fee providers. Later HybridFeeProvider can be removed since it's a sort of duplicate.

size/L

### Description Currently both MemPoolSpaceFeeProvider and BlockstreamInfoFeeProvider has a simple http query and parse solution to provide fee for sending BTC. It would be nice to have a common ancestor...