Chris Siefert

Results 165 comments of Chris Siefert

@seanofthemillers : @cwpearson and I will be going over this PR We need to add code pathways for SYCL as well, so our current plan is to add that to...

I've reached the end of what I'm actually willing to push to your branch. I'm going to push new branch based on this removing the fence changes, since that seems...

@seanofthemillers What's the logic on the Tpetra changes? Something that corrects for people enabling and disabling profiling within the life of a profiling region?

@seanofthemillers Not following. The existing code only pushes/pops a region if Behavior::profilingRegionUseKokkosProfiling() is true. Is there something wrong in the logic of that function?

@seanofthemillers Ah, yes. I was looking at the _other_ constructor. Makes sense now. Tpetra changes look good to me!

If Kokkos profiling is enabled, Teuchos timers include Kokkos profile regions, which will fence.

> > > Also, is Kokkos profiling a runtime option? Yes. You just need to set the right environment variable to point to the Kokkos profiling library of your choice....

ascicgpu033 using the Ifpack2_AdditiveSchwarz unit test on either 1 or 3 processors.

@ndellingwood Use the GenConfig configuration on one of the ascicgpu nodes to reproduce the error.

We should have just deprecated that template parameter...