Need user Display names, not email addresses

[csharpfritz]

This looks funny in the database and we don't want to expose the email address of users who might not want to share their email address

[atifmir]

@csharpfritz if I understood correctly we want to remove email from comments page, user can just enter their display name and make comment?

[csharpfritz]

That's correct.. we don't want to display users emails by default

Jeff

On Fri, Nov 9, 2018 at 1:10 PM atifmir [email protected] wrote:

@csharpfritz https://github.com/csharpfritz if I understood correctly we want to remove email from comments page, user can just enter their display name and make comment?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/csharpfritz/CoreWiki/issues/346#issuecomment-437496094, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEy8ea6hpW3K54xpqQNDGBjQoOiDydNks5ute8ygaJpZM4YW7vW .

[atifmir]

ok cool, thanks

[atifmir]

@csharpfritz when removing email from comment via migration, I encountered error; there is foreign key constraint set between email in comments and article ...... seem like this is constraint using SQLite.

Applying migration '20181110003331_RemovedEmailFromComment'. System.NotSupportedException: SQLite does not support this migration operation ('DropForeignKeyOperation'). For more information, see http://go.microsoft.com/fwlink/?LinkId=723262.

[atifmir]

add migration does not produce the required scaffolding the following manual one I created to drop email column from comments table also does not work , and I get System.NotSupportedException: SQLite does not support this migration operation ('DropColumnOperation'). protected override void Up(MigrationBuilder migrationBuilder) { migrationBuilder.DropColumn( name: "Email", table: "Comments"); } protected override void Down(MigrationBuilder migrationBuilder) { migrationBuilder.AddColumn<string>( name: "Email", table: "Comments", defaultValue:""); }

[kyledavi5]

I may be wrong here but I think you're getting this error because SQLite by design doesn't support dropping columns. I think the schema needs to be dropped and rebuilt with a new migration.