extension
extension copied to clipboard
csfloat
feat: add options page
oh i was planning on finishing up the pr on this branch and merging it when it's ready, it's still kind of a draft
Converted to a draft PR in the meantime, please click Ready for review when you're ready!
Putting it all in one PR is fine with me.
May I know if this PR is going to be merged?
I believe there were some issues with getting this to run properly on Firefox at one point. If you'd like to fork it, feel free.
Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.
Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.
I was just checking this branch, it looked good and built correctly, I was looking to create something like this but this is already too advanced to be discarded imo. I would just change some minor details and add a couple options that I have in mind already.
I'm not sure at all about the issue you're mentioning, it already passed the checks but I would love to see this being merged or approved for merge at least
Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal).
But yeah how about I try fix up those two small issues preventing it to be merged and then you can build on top of that.
Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal).
But yeah how about I try fix up those two small issues preventing it to be merged and then you can build on top of that.
Sounds really good man, would be happy to help if you need it of course
Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with that.
Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with that.
Sure thing man, I'll look into it
@Step7750 Omg... This was the problem the whole time 😭
https://github.com/csfloat/extension/blob/262a725729a9f55d6c2890d51da914b7f36e5126/src/lib/bridge/client.ts#L8
@Step7750 Omg... This was the problem the whole time 😭
https://github.com/csfloat/extension/blob/262a725729a9f55d6c2890d51da914b7f36e5126/src/lib/bridge/client.ts#L8
is it working now? haha
No, I totally missed that the content script <-> background messaging isn't supported for firefox. @Step7750 any input on how you want this to be fixed?