Charles Severance
Charles Severance
I don't like YAML or ini files. PHP is the quickest and most high performance way to do this - it is compiled dynamically. The layout of config-dist.php (i.e. not...
Cool - this was my first contribution to Sakai back in 2002 :)
Since this is a web service and the web service is saying to "delete the grade and comment" we need to do what the web service expects. In reality -...
I am definitely agreeing that a soft delete *is* allowed. What is not allowed is to ignore a request to delete - you cannot have a tool ask for a...
@adrianfish - Did you see my comment about line 2446 above? There are two places to fix in the service.
Yes @adrianfish - I am perfectly happy with a delete method that just does the delete - we can revisit any time - but lets move this forward.
Please fix the second place where it wants to delete the comment. (see above) Could you also change line 2446 to check if the comment from the incoming request isEmpty...
Hey @adrianfish - I want to approve this but your are missing a one line fix described above.
So @adrianfish - I tried to use the review / submit change to get the changes I needed in. I think it worked.
Thanks! Let me come up with some better wording.