RimThreaded icon indicating copy to clipboard operation
RimThreaded copied to clipboard

Psychic Harmonizer has a large TPS impact. (Fixed: (Psychic Harmonizer disappears))

Open qfishpear opened this issue 3 years ago • 12 comments

IMPORTANT: Please first search existing bugs to ensure you are not creating a duplicate bug report!

Describe the bug

  • [x] Fix The psychic harmonizer just disappears randomly when the colony get fairly large. This is the same bug as issue #495 but I can provide more information.
  • [ ] Fix / optimize the performance of the harmonizer (optional)

Steps to reproduce the behavior (VERY IMPORTANT)

  1. Install a psychic harmonizer to a colonist
  2. Wait

Notice: This can only be reproduced when the colony is larger. And the larger the colony is, the more frequently it happens. If you load my save file, this bug can be reproduced in just several days.

Error Log !!! Link to contents of Player.log or Error.log (MUST BE LINK) !!! !!! Link to HugsLib log. (MUST BE LINK) !!! player.log: https://paste.ubuntu.com/p/2DPxyJSf6p/ husglib log: https://gist.github.com/HugsLibRecordKeeper/94524624003de002eb97ac15b74fcfb0

Save file !!! Please add a save file where the issue occurs to speed up testing and fixing of the issue !!! http://transfer.sh/mQ0a4/%E5%96%B5%E5%91%9C4%20%EF%BC%88%E6%B0%B8%E4%B9%85%E6%AD%BB%E4%BA%A1%E6%A8%A1%E5%BC%8F%EF%BC%89.rws

I don't know where to upload a save file so if you can't open the link above and I'll find somewhere else to upload.

Screenshots !!! Add screenshots to help explain your problem here !!! https://z3.ax1x.com/2021/04/02/cerGj0.png

Mod list (For vanilla report, it has to be same as below list.)

  • Harmony
  • Core
  • Royalty
  • HugsLib
  • RimThreaded

qfishpear avatar Apr 02 '21 06:04 qfishpear

Was able to reproduce in RT 1.3.2 using the uploaded save file. After a few days the right-most colonist in the colonist bar loses his psychic harmonizer. Wasn't able to upload hugslib log, so this is the link to the player.log file containing the error:

https://pastebin.com/ndrLyUax

15adhami avatar Apr 15 '21 01:04 15adhami

Also reproduceable in RT 2.0.7, but with constant error spam. player.log file:

https://pastebin.com/uy5u6iVh

15adhami avatar Apr 15 '21 01:04 15adhami

I was unable to reproduce in 2.1.4. I spawned 100+ colonists and waited a day. Can someone please retest with version 2.1.4?

cseelhoff avatar May 14 '21 02:05 cseelhoff

@15adhami @qfishpear can you please upload the savefile again? it's no longer available on the original link

pastorismylord avatar May 15 '21 06:05 pastorismylord

Tested on 2.1.5, harmonizers no longer disappear. But there is major TPS loss while harmonizers are active. Attached a save file I made. When tested on 1.3.2, harmonizers instantly disappear but there is no TPS loss.

harmonizer bug.zip

15adhami avatar May 15 '21 07:05 15adhami

@cseelhoff may be worth to keep this one around for the performance release

pastorismylord avatar May 15 '21 07:05 pastorismylord

@pastorismylord remove the ".txt" suffix after downloading it (github don't allow me to upload .rws file) 喵呜4 (永久死亡模式).rws.txt

qfishpear avatar May 15 '21 08:05 qfishpear

issue no longer present on 2.2.0

pastorismylord avatar May 17 '21 21:05 pastorismylord

tested in 2.1.5 the Harmonizer doesn't disappear. but i noticed TPS drop from 3000 TPS to about 1600 TPS with about 20 colonists and two of them with harmonizers

Niilo007 avatar May 19 '21 18:05 Niilo007

Tested in 2.2.9, TPS drop still occurring with harmonizers. Tested using the save file I uploaded in my earlier comment.

15adhami avatar May 24 '21 13:05 15adhami

Tested on 2.2.14. It's still reproducable. Save file: http://transfer.sh/1LQSVYV/test_harmonizer.rws if you find the above one with too low TPS, I've cleaned up the battlefield and it's also reproducable: http://transfer.sh/1peJLBk/test_harmonizer-3.rws The harmonizer disappears just in a few days.

qfishpear avatar May 25 '21 22:05 qfishpear

Issues with RT 2.3.6. Low FPS when there are harmonizers, and on this save there are constant errors: test_harmonizer-3.zip

15adhami avatar Jun 18 '21 02:06 15adhami