sage-on-gentoo icon indicating copy to clipboard operation
sage-on-gentoo copied to clipboard

Missing patch

Open Etn40ff opened this issue 11 months ago • 11 comments
trafficstars

It looks 10.5 is missing a patch:

>>> Emerging (1 of 5) sci-mathematics/sagemath-standard-10.5::sage-on-gentoo
 * Fetching files in the background.
 * To view fetch progress, run in another terminal:
 * tail -f /var/log/emerge-fetch.log
 * sagemath_standard-10.5.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                                                                                                                                                                       [ ok ]
>>> Unpacking source...
>>> Unpacking sagemath_standard-10.5.tar.gz to /var/tmp/portage/sci-mathematics/sagemath-standard-10.5/work
>>> Source unpacked in /var/tmp/portage/sci-mathematics/sagemath-standard-10.5/work
>>> Preparing source in /var/tmp/portage/sci-mathematics/sagemath-standard-10.5/work/sagemath_standard-10.5 ...
 * Applying mpmath.patch ...                                                                                                                                                                                                                                                                                                                                                                                                       [ ok ]
 * Applying sagemath-standard-10.4-env.patch ...
patching file sage/misc/copying.py
Hunk #1 succeeded at 3 with fuzz 2 (offset -1 lines).
Hunk #2 succeeded at 14 (offset -1 lines).                                                                                                                                                                                                                                                                                                                                                                                         [ ok ]
 * Applying sage_exec-9.3.patch ...                                                                                                                                                                                                                                                                                                                                                                                                [ ok ]
 * Applying sagemath-standard-10.4b-neutering.patch ...                                                                                                                                                                                                                                                                                                                                                                            [ ok ]
 * Build system packages:
 *   dev-python/gpep517            : 16
 *   dev-python/installer          : 0.7.0
 *   dev-python/cython             : 3.0.11
 *   dev-python/setuptools         : 75.5.0
 *   dev-python/setuptools-rust    :
 *   dev-python/setuptools-scm     : 8.1.0
 *   dev-python/wheel              : 0.44.0
Processing for src/sage
/var/tmp/portage/sci-mathematics/sagemath-standard-10.5/distdir/sagemath_PR38962.patch: No such file or directory

Etn40ff avatar Dec 04 '24 08:12 Etn40ff

How strange. Let me look deeper, probably something very silly.

kiwifb avatar Dec 04 '24 08:12 kiwifb

OK, a funky interaction between my patch eclass and the pypi eclass about SRC_URI that I did not properly document and I did not propagate the fix that is in 10.4 properly to 10.5. I should find something better.

kiwifb avatar Dec 04 '24 08:12 kiwifb

And sage_docbuild has the same issue.

kiwifb avatar Dec 04 '24 08:12 kiwifb

Actually no, sage_docbuild was not affected. Fix pushed, should be available in the next 15mn, time for the overlay mirror to sync.

kiwifb avatar Dec 04 '24 08:12 kiwifb

Not yet:

!!! Fetched file: sagemath_PR38962.patch VERIFY FAILED!
!!! Reason: Filesize does not match recorded size
!!! Got:      8536
!!! Expected: 4352
Refetching... File renamed to '/usr/portage/distfiles/sagemath_PR38962.patch._checksum_failure_.fulrsd6t'

Etn40ff avatar Dec 04 '24 12:12 Etn40ff

OK, the file source changed yesterday. Bad timing but you caught it. I will check if it still applies and update.

kiwifb avatar Dec 04 '24 19:12 kiwifb

Manifest updated. However it looks like it may change again. I'll try to keep an eye on it.

kiwifb avatar Dec 04 '24 23:12 kiwifb

Can this be made into a diff between to commits rather than a PR? In this way one may freeze the patch in a known working state

Etn40ff avatar Dec 05 '24 07:12 Etn40ff

Also, you did not push

Etn40ff avatar Dec 05 '24 07:12 Etn40ff

Can this be made into a diff between to commits rather than a PR? In this way one may freeze the patch in a known working state

Yes, it can. I was trying to avoid work around here :) Darn, I really forgot to push. Done now.

kiwifb avatar Dec 05 '24 07:12 kiwifb

Works now, thanks

Etn40ff avatar Dec 05 '24 09:12 Etn40ff