github-actions-hero icon indicating copy to clipboard operation
github-actions-hero copied to clipboard

Accepts solutions that don't match the requirements, doesn't support multiple paths

Open 42degrees opened this issue 2 years ago • 0 comments

Thanks for a cool site!

This is about lesson 5, Filter by paths. The requirements specifically mention .jpg files, but it accepts matching all files.

For example, it accepts this:

  • 'photos/*'

and this:

  • 'photos/.'

Even though these are not specific to jpg files (and will certainly get the user in trouble when "optimizing images".

Also, it gets confused if you include multiple paths, for example this fails, but should probably be accepted:

  • 'photos/*.jpg'
  • 'photos/*.JPG'

Interestingly, this alternate solution for handling of files with multiple cases works fine as long as there is only one path:

  • 'photos/*.[jJ][pP][gG]'

42degrees avatar Jan 17 '24 18:01 42degrees