csarven
WIP: Refactoring
This one goes on top of host-out-of-www (once/if that's merged).
The objective is smaller bits of more easily testable/understandable/reusable code.
The goal is to end up with three chunks of code: server, client, and cli. The cli is the command line interface to client. The other two do what they say on the tin. :grin:
👍 for merging this @csarven, very much needed. For the server, I hope we end up with different express middleware that can be used separately to run inboxes as a library.
I'm also +1 to this but IIRC the changes broke https://github.com/csarven/ldn-tests/ . I'd prefer to merge once ldn-tests factors in the changes in mayktso. [mayktso was initially created for ldn-tests and then pulled out.. I don't want to track two different mayktsos in production.]
Of course, but what is still needed for that? And https://github.com/csarven/ldn-tests/ should probably use this repo as a dependency/library?
Besides bring this PR up to date with current master? ..
Off the top of my head, we need to be careful with the URL and file paths.
ldn-tests already includes maytkso in its package as a dependency.
ldn-tests already includes maytkso in its package as a dependency. Ah misunderstood.
Maybe it's better to redo the refactoring on the current master with this PR as inspiration.
@csarven the conflicts don't seem that bad, actually. You can use the "Resolve conflicts" button here to preview (and manage them too, actually).
I'm not familiar enough with ldn-tests to know what I've broken (or not) about it. You mentioned URL and file paths. Are there enough tests in that package that could confirm (or deny) any refactoring success?
I'm happy to take another crack at this. 😃