CsaGuzzleBundle icon indicating copy to clipboard operation
CsaGuzzleBundle copied to clipboard

Add a background color for the OPTIONS requests

Open coudenysj opened this issue 7 years ago • 3 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache License 2.0

coudenysj avatar Feb 23 '18 15:02 coudenysj

Hi @coudenysj. Unfortunately that PR is incomplete. You also need to update _badge.sass, and re-generate the CSS file. Could you do that?

Cheers!

csarrazi avatar Feb 27 '18 16:02 csarrazi

What should be changed in _badge.sass? The methods are not used there.

Plus: I unfortunately don't have the tools to process sass files :/

coudenysj avatar Feb 28 '18 18:02 coudenysj

Okay. I'll take over your PR, then :)

No big deal! In any case, the minified CSS file not generated by CI, but needs to be added in the PR for the changes to be applied. I'll create a PR based on your branch, and merge that one. In the mean time, keep your PR open :)

csarrazi avatar Mar 09 '18 10:03 csarrazi