Results 230 comments of Carl

> as tecnical triage, there is the switch `--disable-remote-fonts` This could be turned to a flag? > can you help me understand the privacy issue? How does downloading a webfont...

> KO, surely prevents the autofill compatibility service from accessing it (linked to Play Services) and does not contain native autofill, to be confirmed by Bromite experts It is not...

> * Bromite 96.0.4664.54 from Bromite FDroid @marcoXbresciani was it working with Bromite v95? [This patch](https://github.com/bromite/bromite/issues/1534) was introduced in v96 (assuming that nothing else in vanilla Chromium is also responsible);...

@marcoXbresciani please [submit a bug](https://github.com/bromite/bromite/issues/new?assignees=&labels=&template=bug_report.md) so that others can try reproducing the issue

> I think there's potential for additional processing in the future. As a general rule I avoid adding code for the "just in case" situation, but if you have some...

> However, I also realized your code will break if the comment delimiter appears in strings. I don't know if any substitutions could be affected by this, though. Yes, I...

@Luka-Filipovic I create git commits after performing the domain substitutions and there are several MBs of unwanted changes; I also think that changing the timestamp alone won't prevent the file...

> Not doing domsub in test files could also help with your problem, and it can be made only by parsing the file name. I already covered this by excluding...

> That's interesting. What use-case do you have where you'd want to build Chromium once first, apply domain substitution, then re-run the build? The Bromite build process is a bit...

> [Every](https://github.com/ungoogled-software/ungoogled-chromium/commit/eb5aa1a0431937aede292acd2f9481d3a26ab575) [other](https://github.com/ungoogled-software/ungoogled-chromium/commit/009c8e19255a8a0255ec0be40eb4872471318463) [later](https://github.com/ungoogled-software/ungoogled-chromium/commit/d33495850fe545e2efc09cc7c3c749cb17e5e0df) [Bromite](https://github.com/ungoogled-software/ungoogled-chromium/commit/56065d81dcf1301d6e80c26e4397b754b6835e50) patch was committed by Eloston directly presumably by copying it from GPL-licensed Bromite tree into the BSD licensed UC tree. This fact deserves further investigation....