check50 icon indicating copy to clipboard operation
check50 copied to clipboard

commit.gpgSign causes an error with uploads

Open Douile opened this issue 4 years ago • 1 comments

If a user has commit.gpgSign set to true in their global git config check50 will error when trying to upload.

Traceback (most recent call last):
  File "/home/tom/.local/bin/check50", line 33, in <module>
    sys.exit(load_entry_point('check50==3.2.2', 'console_scripts', 'check50')())
  File "/home/tom/.local/lib/python3.9/site-packages/check50/__main__.py", line 336, in main
    commit_hash = lib50.push("check50", internal.slug, internal.CONFIG_LOADER, data={"check50": True})[1]
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 73, in push
    username, commit_hash = upload(slug, user, tool, data)
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 354, in upload
    _run(git("commit -m {msg} --allow-empty", msg=commit_message))
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 704, in _run
    command_output = child.read().strip().replace("\r\n", "\n")
  File "/usr/lib/python3.9/contextlib.py", line 124, in __exit__
    next(self.gen)
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 697, in _spawn
    raise Error()
lib50._errors.Error
Sorry, something is wrong! check50 ran into an error.
Please let CS50 know by emailing the error above to [email protected].

Douile avatar Apr 05 '21 18:04 Douile

^ Should be fixable by just adding --no-gpg-sign to the git args

Douile avatar Apr 07 '21 15:04 Douile