reva icon indicating copy to clipboard operation
reva copied to clipboard

omit unneeded ocm request when deleting space shares

Open butonic opened this issue 1 year ago • 1 comments

We no longer check if a share is an ocm sharee if listng ocm shares has been disabled anyway. This saves a request that would fail anyway.

butonic avatar Apr 22 '24 11:04 butonic

@butonic is this still needed?

tbsbdr avatar May 27 '24 09:05 tbsbdr

yes ... ocis logs during tests are spammed with error level logs

{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"851898bd41c17fc1c35437025848f8a1","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:04:20Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"6f622364c5ff47f71dcfaed0ad0c8f2c","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:31Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"6e96fbda713cc7e52c85197e6bfcc590","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:31Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"9f04b517ff38371228d95030ac62bf56","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:45Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"0c93e71256684e4d5a6373bcb920a181","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:07Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"1d22d5ae5805653e6a9cbc75644ae6a8","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:07Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"e95fc58e15b1439f05233eb0e9f8192f","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:18Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"3400c48c7bc93e3960e2ba00fded7d51","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:30Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"95bb7608c7ce5a58b5ca5b5e6f78d79a","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:06Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"1c0c75a8e2313a59f3433140b663dcf4","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:09Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"e772b9526a0fd8c119c4024822c4349c","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:43Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"9a18a844165d2c2240e2a5162d5194ab","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:55Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"1001a0e97f95ae4035ce168d1efd5d50","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:43Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"10b4ced116cd44ba70aa861bf82286ad","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:54Z","message":"error calling GetOCMShareProviderClient"}

butonic avatar Aug 01 '24 15:08 butonic