reva icon indicating copy to clipboard operation
reva copied to clipboard

Spaces registry: path templates don't obey mountpoints

Open ishank011 opened this issue 2 years ago • 2 comments

For a storageprovider mounted at /users/[l-z]

https://github.com/cs3org/reva/blob/bdbc57ff6f1d9c1ffc8303045d8fcf0b7fb3031e/pkg/storage/registry/spaces/spaces_test.go#L216-L223

it's expected that a space with path /users/Alice would be returned

https://github.com/cs3org/reva/blob/bdbc57ff6f1d9c1ffc8303045d8fcf0b7fb3031e/pkg/storage/registry/spaces/spaces_test.go#L339-L353

@micbar @butonic

ishank011 avatar May 09 '22 09:05 ishank011

umm /users/[l-z] does not make sense for a user with username Alice, does it? If you mean that a storageprovider with the mount_point /users/[a-k] should return a space path /users/Alice, then I agree.

butonic avatar May 09 '22 12:05 butonic

umm /users/[l-z] does not make sense for a user with username Alice, does it?

Exactly what I'm saying. If alice sends a ListStorageProviders request with a resourceID filter corresponding to a personal storage provider mounted at /users/[l-z], it should return a not found error. Currently it just frames the path depending on the user sending the request irrespective of whether the path would actually exist on the provider or not.

ishank011 avatar May 09 '22 12:05 ishank011