pygdbmi icon indicating copy to clipboard operation
pygdbmi copied to clipboard

Update gdbcontroller.py

Open matkuki opened this issue 1 year ago • 4 comments

Line 124 added: this fixes a crash on Windows, when calling the exit method.

  • [] I have added an entry to CHANGELOG.md

Summary of changes

Test plan

Tested by running

# command(s) to exercise these changes

matkuki avatar Jul 09 '22 09:07 matkuki

What version of gdbgui are you using? I didn’t think it worked on windows.

cs01 avatar Jul 09 '22 15:07 cs01

0.10.0.2, installed with pip install pygdbmi. Except for this error, it works without problems 👍

matkuki avatar Jul 09 '22 17:07 matkuki

Forgot to mention that I'm using it for debugging embedded systems, not desktop applications.

matkuki avatar Jul 09 '22 17:07 matkuki

@matkuki Sorry for the delay! Your patch looks good.

Can you please add a changelog entry? Looks at existing ones for inspiration and add it somewhere under ## 0.10.0.3.

barisione avatar Aug 07 '22 17:08 barisione

Agreed, looks good other than the changelog is missing an entry

cs01 avatar Aug 09 '22 04:08 cs01

I updated your patch (leaving you as author!) to add a changelog entry. I had to make a new PR so I could push my changes, see https://github.com/cs01/pygdbmi/pull/79.

barisione avatar Aug 14 '22 08:08 barisione