pygdbmi
pygdbmi copied to clipboard
Update gdbcontroller.py
Line 124 added: this fixes a crash on Windows, when calling the exit
method.
- [] I have added an entry to
CHANGELOG.md
Summary of changes
Test plan
Tested by running
# command(s) to exercise these changes
What version of gdbgui are you using? I didn’t think it worked on windows.
0.10.0.2
, installed with pip install pygdbmi
.
Except for this error, it works without problems 👍
Forgot to mention that I'm using it for debugging embedded systems, not desktop applications.
@matkuki Sorry for the delay! Your patch looks good.
Can you please add a changelog entry?
Looks at existing ones for inspiration and add it somewhere under ## 0.10.0.3
.
Agreed, looks good other than the changelog is missing an entry
I updated your patch (leaving you as author!) to add a changelog entry. I had to make a new PR so I could push my changes, see https://github.com/cs01/pygdbmi/pull/79.