gdbgui icon indicating copy to clipboard operation
gdbgui copied to clipboard

Do not crash on UTF-8 decode errors

Open kubouch opened this issue 2 years ago • 2 comments

  • [] I have added an entry to CHANGELOG.md, or an entry is not needed for this change

Summary of changes

This PR implements a fix suggested in https://github.com/cs01/gdbgui/issues/407.

There are also other UTF-8 issues that might be related to this: https://github.com/cs01/gdbgui/issues/130 https://github.com/cs01/gdbgui/issues/347 https://github.com/cs01/gdbgui/issues/292

Test plan

Tested by running

# command(s) to exercise these changes

kubouch avatar Mar 21 '22 12:03 kubouch

I haven't actually tested the changes yet but I can try later when I have more time.

kubouch avatar Mar 21 '22 12:03 kubouch

This looks good, will merge if it's tested

cs01 avatar Jun 22 '22 00:06 cs01

Tested it out here on a program that had been causing gdbgui to crash for me and it seems to be working well. Can provide source if necessary, but I'm unsure if the same error will crop up on other machines.

AuroransSolis avatar Jan 19 '23 08:01 AuroransSolis

Sorry, I moved to other projects and haven't used gdbgui or even gdb since, I don't have a reproduction example anymore.

kubouch avatar Jan 19 '23 12:01 kubouch

I meant that I can provide the source to reproduce the issue. Your patch did work very well on my machine, at least, so it has that going for it.

AuroransSolis avatar Feb 03 '23 05:02 AuroransSolis

You can paste the source here.

kubouch avatar Feb 03 '23 07:02 kubouch

Thank you!

cs01 avatar Oct 18 '23 05:10 cs01