solc-select icon indicating copy to clipboard operation
solc-select copied to clipboard

Store all binaries in https://github.com/crytic/solc

Open montyly opened this issue 3 years ago • 2 comments

We frequently have timeout in our CI (ex: https://github.com/crytic/slither/runs/7537262148?check_suite_focus=true) because when solc-select installs everything, it makes a lot of requests to [binaries.soliditylang](https://binaries.soliditylang.org).

We could store all the binaries in https://github.com/crytic/solc, and when the user run install all

  • Clone crytic/solc, and copy all the binaries at once
  • And only switch to https://binaries.soliditylang.org for the versions that are not there.

This will significantly reduce the number of requests and prevent the CI to fail.

We will need to update crytic/solc more often, but I think that would be ok.

montyly avatar Jul 27 '22 09:07 montyly

Foundation is in place via PR#3 to crytic/solc. Still some work needed in solc-select to utilize the newly added solc binaries.

In the meantime, do we really need to solc-select install all before slither tests? Why not install only the versions that are actually used? No matter how much crytic/solc helps, slither ci will be much faster & stable if it doesn't download solc versions that it doesn't needed.

bohendo avatar Oct 28 '22 18:10 bohendo

We can switch to individual version for the detectors, but the AST parsing actually use all the versions, so we won't be able to save time there.

montyly avatar Jan 03 '23 13:01 montyly