slither icon indicating copy to clipboard operation
slither copied to clipboard

chore: fix typo

Open valeriypushkar opened this issue 1 year ago • 3 comments

Small typo fix in _process function.

valeriypushkar avatar Oct 30 '24 09:10 valeriypushkar

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Valery Pushkar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 30 '24 09:10 CLAassistant

Hi! thanks for the PR. I suspect this might have been done on purpose to keep mypy happy and it might not be a typo. We don't seem to be running mypy on CI these days though 🤔

elopez avatar Oct 30 '24 10:10 elopez

Hi @elopez ! I've just run mypy locally on the whole project. Mypy found some issues but not in the fixed code lines. Mypy version is 1.13.0 (compiled: yes). The issues in main.py file are:

__main__.py:17: error: Cannot find implementation or library stub for module named "crytic_compile"  [import-not-found]
__main__.py:18: error: Cannot find implementation or library stub for module named "crytic_compile.platform.standard"  [import-not-found]
__main__.py:19: error: Cannot find implementation or library stub for module named "crytic_compile.platform.etherscan"  [import-not-found]
__main__.py:253: error: Incompatible return value type (got "set[type[AbstractDetector]]", expected "list[type[AbstractDetector]]")  [return-value]
__main__.py:885: error: Function "output_to_sarif" could always be true in boolean context  [truthy-function]

valeriypushkar avatar Oct 30 '24 10:10 valeriypushkar