slither icon indicating copy to clipboard operation
slither copied to clipboard

Published 20 hours ago • verified publisher icon crytic

Improve constant parsing

Open elopez opened this issue 3 years ago • 2 comments

This PR improves and unifies constant parsing through the following:

  • Using Fraction instead of Decimal, to eliminate precision loss and rounding on constants
  • Unified parsing of integers through convert_string_to_int/fraction
  • Correction of unary minus parsing (the negation was not being applied)
  • Tests for rational and scientific notation constants

elopez avatar Sep 18 '22 14:09 elopez

This pull request introduces 1 alert when merging 2879514f23ad058abb0bd3c42259507eb06ba4b9 into 719e4e98d8980451e7cbd3e1cc94cb078ca902a8 - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Sep 18 '22 15:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 3112f157cad5cd5964468766f430105be1714b8e into 719e4e98d8980451e7cbd3e1cc94cb078ca902a8 - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Sep 18 '22 16:09 lgtm-com[bot]

This is great, thanks @elopez

montyly avatar Sep 26 '22 10:09 montyly