not-so-smart-contracts icon indicating copy to clipboard operation
not-so-smart-contracts copied to clipboard

solidity compile warnings which are errors

Open rocky opened this issue 6 years ago • 1 comments

I am using solc version Version: 0.4.24+commit.e67f0147.Linux.g++

$ solc missing_constructor/Missing.sol
Missing.sol:23:23: Warning: Using contract member "balance" inherited from the address type is deprecated. Convert the contract to "address" type to access the member, for example use "address(contract).balance" instead.
       owner.transfer(this.balance);
                      ^----------^

and

$ solc reentrancy/DAO_source_code/DAO.sol 
reentrancy/DAO_source_code/DAO.sol:91:52: Error: Expected ';' but got '}'
    modifier noEther() {if (msg.value > 0) throw; _}

and two others. Look for "Unconfigured" in the chart in https://ethereumanalysisbenchmarks.github.io/nssc/index.html

rocky avatar Aug 06 '18 19:08 rocky

We're scrapping the old benchmarks so this can be closed.

muellerberndt avatar Sep 19 '18 10:09 muellerberndt