echidna icon indicating copy to clipboard operation
echidna copied to clipboard

coverage: count number of executions per line

Open elopez opened this issue 1 year ago • 11 comments

elopez avatar May 28 '24 16:05 elopez

I think either the workers will be frequently sending events (quite bad) or some counter will not be properly updated (not so bad, still not great).

gustavo-grieco avatar May 28 '24 17:05 gustavo-grieco

@elopez can you also include the changes from here? https://github.com/crytic/echidna/pull/1110

gustavo-grieco avatar May 28 '24 17:05 gustavo-grieco

This is awesome, I want this feature so bad :laughing:

rappie avatar May 30 '24 10:05 rappie

I did a second attempt at implementing this a safer way. The code is quite ugly right now but if anyone wants to test/review it before I spend some more time on it I'd appreciate it 👍

elopez avatar Jul 08 '24 15:07 elopez

I don't see this branch under Actions to download the binary :thinking:

rappie avatar Jul 08 '24 15:07 rappie

I think it is because it is a draft, let me convert it a proper PR

gustavo-grieco avatar Jul 08 '24 15:07 gustavo-grieco

@rappie There was a small git conflict, hopefully it builds now that I resolved it 👍

elopez avatar Jul 08 '24 18:07 elopez

@samalws-tob can you take a look to this PR?

gustavo-grieco avatar Jul 09 '24 19:07 gustavo-grieco

I benchmarked this, looks like it cuts performance (calls/s) in half

samalws-tob avatar Sep 03 '24 16:09 samalws-tob

in #1305 tried doing type StatsInfo = ExecQty instead of type StatsInfo = (ExecQty, RevertQty) because I thought the issue might've had to do with tuples being non-strict, but it's still far slower than master

samalws-tob avatar Sep 10 '24 17:09 samalws-tob

I'm still very interested in this, despite the performance loss. It would be great to have this in master as a togglable feature :slightly_smiling_face:

rappie avatar Sep 10 '24 19:09 rappie