crytic-compile icon indicating copy to clipboard operation
crytic-compile copied to clipboard

feat: arguments should be supported in both str and native format

Open yxliang01 opened this issue 5 years ago • 2 comments

Many arguments are expected to be serialized str e.g. solc_args. However, crytic-compile will often need to deserialize them and also serialize again.

While it works perfectly for user inputs (e.g. arguments taken from CLI), it would be a unnecessary overhead when CryticCompile is used as a library that developers need to serialize for no use (because soon will be deserized in CryticCompile).

yxliang01 avatar Sep 16 '20 07:09 yxliang01

Hi @yxliang01 ,

Do you have an example that you could share?

If I understand correctly, you want to give to solc_args either a string, or a list of strings, is that correct?

montyly avatar Sep 21 '20 12:09 montyly

@montyly Yes, your understanding is correct. For my projects, the arguments are constructed naturally in a form of list of strings. But, to let crytic-compile use, I have to join them. This effort looks useless because crytic-compile will split it again.

yxliang01 avatar Nov 03 '20 18:11 yxliang01